internal/database: only log QueryRow debug info if error

julieqiu · julieqiu · commit 77c99373df98 · 2020-10-16T15:32:07.000Z
QueryRow debug info is only logged now if there is an error. Logging on every call resulted in too much noise. For golang/go#39629 Change-Id: I5e5be0b1b4bdeda0ebe2618a7036fbf521c225a7 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/262702 Trust: Julie Qiu <julie@golang.org> Run-TryBot: Julie Qiu <julie@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com>
diff --git a/internal/database/database.go b/internal/database/database.go
@@ -114,8 +114,6 @@ func (db *DB) QueryRow(ctx context.Context, query string, args ...interface{}) *
 		msg := fmt.Sprintf("args=%v; elapsed=%q, start=%q, deadline=%q", args, time.Since(start), start, d)
 		if ctx.Err() != nil {
 			log.Errorf(ctx, "QueryRow context error: %v "+msg, ctx.Err())
-		} else {
-			log.Debugf(ctx, "QueryRow: "+msg)
 		}
 		logQuery(ctx, query, args, db.instanceID)(nil)
 	}()

Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,6 @@ func (db DB) QueryRow(ctx context.Context, query string, args ...interface{}) `
`114`	`114`	`msg := fmt.Sprintf("args=%v; elapsed=%q, start=%q, deadline=%q", args, time.Since(start), start, d)`
`115`	`115`	`if ctx.Err() != nil {`
`116`	`116`	`log.Errorf(ctx, "QueryRow context error: %v "+msg, ctx.Err())`
`117`		`- } else {`
`118`		`- log.Debugf(ctx, "QueryRow: "+msg)`
`119`	`117`	`}`
`120`	`118`	`logQuery(ctx, query, args, db.instanceID)(nil)`
`121`	`119`	`}()`