Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Signature help tooltip shows up when accepting a suggestion when "editor.parameterHints.enabled" is false #3071

Closed
hyangah opened this issue Nov 29, 2023 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Nov 29, 2023

The language server middleware injects a follow up command for each completion item which triggers parameter hint if editor.parameterHints is set.

if (paramHintsEnabled) {

This is not a boolean setting (the bug was introduced in https://go-review.googlesource.com/c/vscode-go/+/382234 sorry). As a result, this is always truthy.
We should use editor.parameterHints.enabled instead.

@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 29, 2023
@hyangah hyangah added this to the v0.41.0 milestone Nov 29, 2023
@gopherbot gopherbot modified the milestones: v0.41.0, Untriaged Nov 29, 2023
@hyangah hyangah modified the milestones: Untriaged, v0.41.0 Nov 30, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/546155 mentions this issue: src/language/goLanguageServer: fix parameter hint setting query

@hyangah hyangah modified the milestones: v0.41.0, v0.40.1 Dec 19, 2023
@golang golang locked and limited conversation to collaborators Dec 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants