Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

activation: plugin doesn't report failure to parse "go env" output #555

Closed
noxer opened this issue Aug 20, 2020 · 1 comment
Closed

activation: plugin doesn't report failure to parse "go env" output #555

noxer opened this issue Aug 20, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@noxer
Copy link

noxer commented Aug 20, 2020

What version of Go, VS Code & VS Code Go extension are you using?

  • Run go version to get version of Go
    • go version go1.15 windows/amd64
  • Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
    • 1.48.0
    • db40434f562994116e5b21c24015a2e40b2504e6
    • x64
  • Check your installed extensions to get the version of the VS Code Go extension
    • v0.16.1

Describe the bug

I managed to set the wrong GOTMPDIR using go env -w. This resulted in every call to go returning the error message go: creating work dir: CreateFile x: The system cannot find the file specified. (where x is the path I set). Now the VS Code Go plugin can't parse the return of go env anymore and doesn't work. Instead of displaying a parsing error, it either silently fails (e.g. when trying to update the Go Tools) or it displays: "Error: TypeError: Cannot read property 'lt' of undefined" (e.g. when trying to save a .go file).

Steps to reproduce the behavior:

  1. Run go env -w GOTMPDIR=x
  2. Open a Go project in VS Code
  3. Try to save a .go file, try to update the Go tools.
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 21, 2020
@hyangah hyangah added this to the Backlog milestone Aug 21, 2020
@hyangah hyangah changed the title Plugin doesn't report failure to parse "go env" output activation: plugin doesn't report failure to parse "go env" output Sep 3, 2020
@hyangah hyangah modified the milestones: Backlog, v0.17.0 Sep 3, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/253601 mentions this issue: src/goInstallTools: report go env failure

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants