Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Severity #1057

Open
2 tasks done
ghost opened this issue Jun 7, 2024 · 0 comments
Open
2 tasks done

Severity #1057

ghost opened this issue Jun 7, 2024 · 0 comments
Labels
question Further information is requested

Comments

@ghost
Copy link

ghost commented Jun 7, 2024

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

Currently all lint actions show with a severity of error in GitHub Actions. Using the now deprecated github-actions output format was able to differentiate severity levels but this does not appear to be possible with the colored-line-output format.

Describe the solution you'd like.

  1. A new format or amendment to colored-line-output that includes severity and an appropriate problem matcher to extract the severity would work

Describe alternatives you've considered.

Using the github-actions output format, but that seems to be deprecated so I'm not sure how long that would work for.

Additional context.

I noticed the golangci-lint-action problem matcher pattern is different than the go one, and unless the golangci-lint problem matcher is enabled with problem-matchers: true the output doesn't seem to be picked up at all. If the rationale for using colored-line-output with its limitations was that it maintained compatibility with the default go problem pattern matcher then that's seemingly already not the case.

@ldez ldez added the question Further information is requested label Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant