fix: packages.Load, go list, and typcheck

Author: ldez

pkg/golinters/goanalysis/runner_loadingpackage.go

@@ -434,6 +434,7 @@ func (lp *loadingPackage) convertError(err error) []packages.Error {
 		// If you see this error message, please file a bug.
 		lp.log.Warnf("Internal error: error %q (%T) without position", err, err)
 	}
+
 	return errs
 }
 

pkg/golinters/gofmt_common.go

@@ -242,7 +242,7 @@ func extractIssuesFromPatch(patch string, lintCtx *linter.Context, linterName st
 	}
 
 	if len(diffs) == 0 {
-		return nil, fmt.Errorf("got no diffs from patch parser: %v", diffs)
+		return nil, fmt.Errorf("got no diffs from patch parser: %v", patch)
 	}
 
 	var issues []result.Issue

pkg/lint/load.go

@@ -160,7 +160,17 @@ func (cl *ContextLoader) debugPrintLoadedPackages(pkgs []*packages.Package) {
 
 func (cl *ContextLoader) parseLoadedPackagesErrors(pkgs []*packages.Package) error {
 	for _, pkg := range pkgs {
+		var errs []packages.Error
 		for _, err := range pkg.Errors {
+			// quick fix: skip error related to `go list` invocation by packages.Load()
+			// The behavior has been changed between go1.19 and go1.20, the error is now inside the JSON content.
+			// https://github.com/golangci/golangci-lint/pull/3414#issuecomment-1364756303
+			if strings.Contains(err.Msg, "# command-line-arguments") {
+				continue
+			}
+
+			errs = append(errs, err)
+
 			if strings.Contains(err.Msg, "no Go files") {
 				return errors.Wrapf(exitcodes.ErrNoGoFiles, "package %s", pkg.PkgPath)
 			}
@@ -169,6 +179,8 @@ func (cl *ContextLoader) parseLoadedPackagesErrors(pkgs []*packages.Package) err
 				return errors.Wrap(exitcodes.ErrFailure, err.Msg)
 			}
 		}
+
+		pkg.Errors = errs
 	}
 
 	return nil

pkg/lint/runner.go

@@ -208,6 +208,7 @@ func (r Runner) Run(ctx context.Context, linters []*linter.Config, lintCtx *lint
 
 				return
 			}
+
 			issues = append(issues, linterIssues...)
 		})
 	}

test/testdata/notcompiles/typecheck_many_issues.go

@@ -2,8 +2,8 @@
 package testdata
 
 func TypeCheckBadCalls() {
-	typecheckNotExists1.F1() // want "undeclared name: `typecheckNotExists1`"
-	typecheckNotExists2.F2() // want "undeclared name: `typecheckNotExists2`"
-	typecheckNotExists3.F3() // want "undeclared name: `typecheckNotExists3`"
-	typecheckNotExists4.F4() // want "undeclared name: `typecheckNotExists4`"
+	typecheckNotExists1.F1() // want "undefined: typecheckNotExists1"
+	typecheckNotExists2.F2() // want "undefined: typecheckNotExists2"
+	typecheckNotExists3.F3() // want "undefined: typecheckNotExists3"
+	typecheckNotExists4.F4() // want "undefined: typecheckNotExists4"
 }