Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sync UI from VertexAI for Firebase #172

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

1998code
Copy link
Contributor

Description of the change

Follow-up from firebase/firebase-ios-sdk#12887

Motivation

Sync the updated User Interface from VertexAI repo.

Type of change

Choose one: Other

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@1998code
Copy link
Contributor Author

Style fixed 🙈🙏

@andrewheard andrewheard self-requested a review May 16, 2024 14:48
@andrewheard
Copy link
Collaborator

Style fixed 🙈🙏

I used to forget to do this all the time. Thanks for re-running!

Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions, @1998code!

@andrewheard andrewheard merged commit e8bbb72 into google-gemini:main May 16, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 16, 2024
enefry added a commit to enefry/generative-ai-swift that referenced this pull request Jun 12, 2024
* commit '54784005b57c2235a7669e0c12e8dafa68f0ca5f':
  Log server error responses without `-GoogleGenerativeAIDebugLogEnabled` (google-gemini#177)
  Send `GenerateContentRequest` in `CountTokensRequest` (google-gemini#175)
  Add `responseSchema` to `GenerationConfig` (google-gemini#176)
  Update models in samples and README to `gemini-1.5-flash-latest` (google-gemini#173)
  Sync UI from VertexAI for Firebase (google-gemini#172)
  Increment SDK version to `0.5.4` (google-gemini#171)
  Add default `RequestOptions.timeout` of 300 seconds (google-gemini#170)
  Delete repo specific Issue Template (google-gemini#169)
  Increment SDK version to `0.5.3` (google-gemini#167)
  Make `text` computed property handle mixed-parts responses (google-gemini#165)
  update doc comments (google-gemini#166)
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants