Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug in slate_decomp_q_agent #26

Open
rahul-zomato opened this issue Nov 1, 2022 · 2 comments
Open

Bug in slate_decomp_q_agent #26

rahul-zomato opened this issue Nov 1, 2022 · 2 comments

Comments

@rahul-zomato
Copy link

self._replay_next_target_net_outputs = self._network_adapter( self._replay.states, 'Target')

should be

self._replay_next_target_net_outputs = self._network_adapter( self._replay.next_states, 'Target')

at https://github.com/google-research/recsim/blob/master/recsim/agents/slate_decomp_q_agent.py#L518
@rahul-zomato
Copy link
Author

@cwhsu-google

@abhiishek-pal
Copy link

Thanks @rahul-zomato was about to totally skip over this bug.

@rahul-zomato rahul-zomato mentioned this issue Nov 15, 2022
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahul-zomato @abhiishek-pal