Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cannot copy a shadow block #208

Open
rachel-fenichel opened this issue Feb 18, 2025 · 1 comment
Open

Cannot copy a shadow block #208

rachel-fenichel opened this issue Feb 18, 2025 · 1 comment

Comments

@rachel-fenichel
Copy link
Contributor

Thanks for the explanation and demo, that makes a lot of sense. I can't help but favour the plugin's behaviour of turning a shadow block into a real block on edit - since that shows intent from the user to make something concrete. Are there situations or applications in which this wouldn't make sense, or previous discussions I can refer back to learn about the competing needs?

There are downstream consequences of this behaviour on copy and paste, which don't make up with my expectations. I would have assumed you'd be able to copy and paste the contents of an oval, like the text in a "write with shadow" block

Screenshot. Write with shadow (item variable). Write with shadow "how are you". The block containing "how are you" is selected.

I would naively argue that these blocks should be real, and draggable, and copyable. If they are not, then we definitely need some user feedback when they try to copy a block, because currently copy will silently fail and you'll end up surprised by pasting the last thing in the copy buffer.

Originally posted by @kmcnaught in #132

@rachel-fenichel
Copy link
Contributor Author

Shadow blocks can't be copied, likely due to checks for isDeletable and isMovable in blockCopyPreconditionFn in navigation_controller.ts.

It should be possible to copy them, since users can't tell which blocks are shadows and which aren't in Zelos. (I think it should also be possible to copy them in Geras). However, the block needs to be converted from a shadow block to a real block either on copy or on paste.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant