Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Empty action is added to the undo stack when dragging block directly from the toolbox to trash #1458

Open
1 of 2 tasks
vicng opened this issue Nov 18, 2017 · 1 comment
Open
1 of 2 tasks
Labels
component: events help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority

Comments

@vicng
Copy link
Contributor

vicng commented Nov 18, 2017

Problem statement

  • Bug report
  • Feature request

If you drag a block directly from the toolbox straight into the trash, this generates an "undo" action. Rewinding this "undo" action does nothing.

Expected Behavior

No "undo" action should be added to the undo/redo stack.

Actual Behavior

All relevant events (create, move, delete) are added to the stack as a group.

Steps to Reproduce

  1. Open the toolbox and add a block to the workspace.
  2. Now, drag another block straight from the toolbox and into the trash.
  3. Undo the action (Ctrl-Z/Cmd-Z) -> Nothing happens (step 1 should be the thing that's undone).

Additional Information

I think the ideal behavior is to remove these events from the event stack, if this scenario is detected.

@vicng vicng added the issue: bug Describes why the code or behaviour is wrong label Nov 18, 2017
@rachel-fenichel rachel-fenichel added help wanted External contributions actively solicited low priority labels Dec 28, 2017
@cpcallen
Copy link
Contributor

This also occurs if you drag a block from the toolbox and then, before placing it, delete it by dragging it back to the toolbox/flyout.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component: events help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority
Projects
None yet
Development

No branches or pull requests

4 participants