Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Output file with path containing non-Latin Unicode characters on Windows #1133

Open
davschne-unity opened this issue Feb 13, 2024 · 1 comment

Comments

@davschne-unity
Copy link

I've noticed some unusual behavior on Windows with output file paths containing non-Latin Unicode characters:

Non-Latin characters in the output filename

$ brotli.exe -o "Lietuvių Kalbos Žodynu.br" "Hello.txt"

The command works, but the output filename is Lietuviu Kalbos Žodynu.br, not Lietuvių Kalbos Žodynu.br, as expected. (notice "u" versus "ų")

Non-Latin characters in the name of the directory containing the output file

$ brotli.exe -o "Lietuvių Kalbos Žodynu\Hello.br" "Hello.txt"

the command fails with output:

failed to open output file [Lietuviu Kalbos Äodynu\Hello.br]: No such file or directory

By contrast, using these same non-Latin characters in the input path seems to work fine. And the problem doesn't seem to occur on MacOS.

@eustas
Copy link
Collaborator

eustas commented Feb 14, 2024

I believe the problem is that CLI code works with 8-bit filenames. Going to fix that as soon as I have time. Feel free to ping me ~once a week. Thank you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants