Skip to content

Commit d33ab70

Browse files
klueverError Prone Team
authored and
Error Prone Team
committed
Add backreferences to b/216306810
PiperOrigin-RevId: 424125774
1 parent 3f61879 commit d33ab70

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/DoNotCallSuggester.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public Description matchMethod(MethodTree tree, VisitorState state) {
188188
.build();
189189
}
190190

191-
// this code is stolen from MissingOverride.java
191+
// TODO(b/216306810): copied from MissingOverride.java
192192
private static boolean isEffectivelyOverride(Symbol sym, Types types) {
193193
// static methods can't be overrides
194194
if (sym.isStatic()) {

core/src/main/java/com/google/errorprone/bugpatterns/MissingOverride.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public Description matchMethod(MethodTree tree, VisitorState state) {
9494
* Returns the {@link MethodSymbol} of the first method that sym overrides in its supertype
9595
* closure, or {@code null} if no such method exists.
9696
*/
97+
// TODO(b/216306810): consider adding a generalized version of this to ASTHelpers
9798
@Nullable
9899
private MethodSymbol getFirstOverride(Symbol sym, Types types) {
99100
ClassSymbol owner = sym.enclClass();

core/src/main/java/com/google/errorprone/bugpatterns/TooManyParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ private static boolean shouldApplyApiChecks(Tree tree, VisitorState state) {
117117
return true;
118118
}
119119

120-
// Copied from MissingOverride.java
120+
// TODO(b/216306810): copied from MissingOverride.java
121121
private static boolean isEffectivelyOverride(Symbol sym, Types types) {
122122
// static methods can't be overrides
123123
if (sym.isStatic()) {

0 commit comments

Comments
 (0)