Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

too much measure #261

Closed
fanhongwei opened this issue Apr 14, 2017 · 7 comments
Closed

too much measure #261

fanhongwei opened this issue Apr 14, 2017 · 7 comments

Comments

@fanhongwei
Copy link

when flexbox parent view align-items is stretch, view visible changed will call too much measure.

@thagikura
Copy link
Contributor

This is duplicate of #46. Some measurements could be skipped, but basically if the attributes that are going to be relevant of deciding the size of the view, some views have to measured multiple times.

@fanhongwei
Copy link
Author

@thagikura I transformed align-items stretch to Android view match_parent, it is faster.
is there any potential risk?

@thagikura
Copy link
Contributor

If setting as match_parent meets your needs, shouldn't be a problem.

The behavior of those twos are different.
alignItems stretch -> The cross size of the views are stretched to the largest cross size in the same flex line.
match_parent -> Fit to the parent size.

@fanhongwei
Copy link
Author

@thagikura I know the different between alignitems-stretch and match_parent, there is a bug of flexbox-layout,when parent is align-items stretch and child set width or height,CSS Flex will use child own width or height, but flexbox-layout will use align-items stretch。

@thagikura
Copy link
Contributor

Ok, confirmed that there is a difference with the CSS spec with that behavior.
That is different from this issue. Is it possible to file a bug for that?

@fanhongwei
Copy link
Author

done

@thagikura
Copy link
Contributor

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants