Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing configuration parameters should cause tool to fail fast #20

Closed
mikouaj opened this issue Apr 1, 2022 · 0 comments · Fixed by #31
Closed

Missing configuration parameters should cause tool to fail fast #20

mikouaj opened this issue Apr 1, 2022 · 0 comments · Fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@mikouaj
Copy link
Member

mikouaj commented Apr 1, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction
    to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
    not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Debug Output

N/A

Panic Output

N/A

Steps to Reproduce

  1. Run ./gke-policy cluster review command

Expected Behavior

Tool should fail fast as there are no cluster configuration parameters specified.
Contextual (depending on a given command) config validation should happen right after loading the config from cli flags or a file.

Actual Behavior

Tool performs several actions before failing: fetches policies from the default source and parses them.

Reading policy files... [GIT repository: https://github.com/google/gke-policy-automation, branch: main, directory: gke-policies]
Parsing REGO policies...
Error: could not get cluster name: cluster parameters not set

References

N/A

@mikouaj mikouaj added the bug Something isn't working label Apr 1, 2022
@mikouaj mikouaj self-assigned this Apr 8, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant