Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tool fetches cluster details even if there are no policies #45

Closed
mikouaj opened this issue Apr 25, 2022 · 0 comments · Fixed by #60
Closed

Tool fetches cluster details even if there are no policies #45

mikouaj opened this issue Apr 25, 2022 · 0 comments · Fixed by #60
Assignees
Labels
bug Something isn't working

Comments

@mikouaj
Copy link
Member

mikouaj commented Apr 25, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction
    to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
    not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Debug Output

https://gist.github.com/mikouaj/d650889e4f2c70782b21d3875ae1bd7d

Panic Output

N/A

Steps to Reproduce

  1. Run ./gke-policy cluster review with a valid cluster details and valid but empty policy source i.e. empty dir, empty rep

Expected Behavior

The tool fetches from policy sources, detects that there are no actual policies and fails / exists.

Actual Behavior

The tool fetches from policy sources, then fetches cluster details and evaluates them (against nothing).

References

N/A

@mikouaj mikouaj added the bug Something isn't working label Apr 25, 2022
@rickygodoy rickygodoy self-assigned this Apr 25, 2022
@mikouaj mikouaj linked a pull request May 10, 2022 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants