Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor test to first Add(time.Minute), then Round(time.Second). #585

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 8, 2017

This is a minor refactor that is a noop. Do it because the new order seems more readable and logical. It's also more consistent with the comment.

This tiny refactor is extracted from #568.

This is a minor refactor that is a noop. Do it because the new order
seems more readable and logical. It's also more consistent with the
comment.
@dmitshur dmitshur requested a review from gmlewis March 8, 2017 20:33
@dmitshur dmitshur changed the title Modify time first, round after. Refactor test to first Add(time.Minute), then Round(time.Second). Mar 8, 2017
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dmitshur dmitshur merged commit f203066 into master Mar 8, 2017
@dmitshur dmitshur deleted the TestDo_rateLimit_noNetworkCall-refactor branch March 8, 2017 20:35
bubg-dev pushed a commit to bubg-dev/go-github that referenced this pull request Jun 16, 2017
…ogle#585)

This is a minor refactor that is a noop. Do it because the new order
seems more readable and logical. It's also more consistent with the
comment.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants