From f2a71afba958a18a5ef5fde4ed68b6cd0d837380 Mon Sep 17 00:00:00 2001 From: Andrey Date: Thu, 24 Oct 2024 23:23:20 +0300 Subject: [PATCH] Use Comparators.lexicographical instead of Ordering.from in DeclaredMembers --- .../inject/internal/DeclaredMembers.java | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/core/src/com/google/inject/internal/DeclaredMembers.java b/core/src/com/google/inject/internal/DeclaredMembers.java index 376ba62d2f..fe84d26a2d 100644 --- a/core/src/com/google/inject/internal/DeclaredMembers.java +++ b/core/src/com/google/inject/internal/DeclaredMembers.java @@ -15,7 +15,7 @@ */ package com.google.inject.internal; -import com.google.common.collect.Ordering; +import com.google.common.collect.Comparators; import java.lang.reflect.Field; import java.lang.reflect.Method; import java.util.Arrays; @@ -34,26 +34,26 @@ */ public final class DeclaredMembers { - private DeclaredMembers() {} + private DeclaredMembers() {} - public static Field[] getDeclaredFields(Class type) { - return Arrays.stream(type.getDeclaredFields()) - .sorted( - Comparator.comparing(Field::getName) - .thenComparing(Field::getType, Comparator.comparing(Class::getName))) - .toArray(Field[]::new); - } + public static Field[] getDeclaredFields(Class type) { + return Arrays.stream(type.getDeclaredFields()) + .sorted( + Comparator.comparing(Field::getName) + .thenComparing(Field::getType, Comparator.comparing(Class::getName))) + .toArray(Field[]::new); + } - public static Method[] getDeclaredMethods(Class type) { - return Arrays.stream(type.getDeclaredMethods()) - .sorted( - Comparator.comparing(Method::getName) - .thenComparing(Method::getReturnType, Comparator.comparing(Class::getName)) - .thenComparing( - method -> Arrays.asList(method.getParameterTypes()), - // TODO: use Comparators.lexicographical when it's not @Beta. - Ordering.>from(Comparator.comparing(Class::getName)) - .lexicographical())) - .toArray(Method[]::new); - } + public static Method[] getDeclaredMethods(Class type) { + return Arrays.stream(type.getDeclaredMethods()) + .sorted( + Comparator.comparing(Method::getName) + .thenComparing(Method::getReturnType, Comparator.comparing(Class::getName)) + .thenComparing( + method -> Arrays.asList(method.getParameterTypes()), + Comparators.lexicographical(Comparator.comparing(Class::getName)) + ) + ) + .toArray(Method[]::new); + } }