Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support rules_jvm_external or j2cl_maven_import_external private registry #212

Open
tamascsaba opened this issue Sep 4, 2023 · 1 comment

Comments

@tamascsaba
Copy link

Hi 👋
I would like to use j2cl with private maven registry. I checked j2cl_maven_import_external function, but it is only support public repository download:

repository_ctx.download(

It would be great add credential support to download method: https://github.com/bazelbuild/bazel/blob/290fc80a5aae9dea06de52deed7098a5b8443f26/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpDownloader.java#L77

Maybe an other solution when it would be possible integrate with rules_jvm_external rule, which support private registries.
https://github.com/bazelbuild/rules_jvm_external#features

Thank you very much for the response.

@gkdn
Copy link
Member

gkdn commented Sep 6, 2023

It would be good idea to just wrap around rules_jvm_external.

My comment here:

# TODO(b/71517767): This could a simple wrapper around java_import_external if
might not be accurate. We do support source jars with j2cl_library so it might be possible today. Also it could be that I meant something else there, who knows :) Anyway would you like to give it a shot?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants