Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ContentDescription should be null when no need a ContentDescription. #279

Closed
Jaehwa-Noh opened this issue Nov 2, 2024 · 0 comments · Fixed by #280
Closed

ContentDescription should be null when no need a ContentDescription. #279

Jaehwa-Noh opened this issue Nov 2, 2024 · 0 comments · Fixed by #280

Comments

@Jaehwa-Noh
Copy link
Contributor

contentDescription = stringResource(
when (stabilizationMode) {
StabilizationMode.AUTO -> R.string.stabilization_icon_description_auto
StabilizationMode.ON ->
R.string.stabilization_icon_description_preview_and_video
StabilizationMode.HIGH_QUALITY ->
R.string.stabilization_icon_description_video_only
else -> 0
}
),

I know else condition not meet in current condition, but contentDescription should be null when it is no need.
And then stringResource(id = 0) is not null, just a dummy string.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant