Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CMake forces -Werror and -Wthread-safety for all project if adding leveldb as subdirectory with clang #1002

Open
lostystyg opened this issue Apr 1, 2022 · 0 comments · May be fixed by #1255

Comments

@lostystyg
Copy link

Here target_compile_options are set with PUBLIC. If leveldb is inlined to source code of a project and added with add_subdirectory with subsequent target_link_libraries(myproject leveldb), this project is forced to be compiled with -Werror and -Wthread-safety.
Probably add these flags as PRIVATE for each leveldb, leveldbutil and tests targets so the underlying project could control compile options itself

@huww98 huww98 linked a pull request Mar 2, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant