-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move out of the global namespace #626
Comments
Just curious, what is the motivation doing this? PF is an application, not a library, so defining classes in the global namespace doesn't look bad to me. It won't harm to put it in a namespace though. |
We could live without it, but there's a couple reasons I'd like to do it:
I could be wrong, but I think it's pretty common for projects to use their own namespace even if they're not libraries. For example, Django's project generation tool puts files into a project-specific namespace by default (I moved them out to be consistent with the rest of PF) |
I see, sounds good if it's a common practice and can also solve real issues. |
We currently have all our stuff in the global namespace, and it'd be nice to have our modules in our own namespace. The obvious options are either "personfinder" or simply "pf"; I'd prefer "pf" since "personfinder" is kinda long. I don't think we need to worry about "pf" colliding with anything else, especially since that name on PyPI is occupied by a project that its owner is apparently not very interested in.
There's not really a good time to do this, but the move to Python 3 might be the least bad time to do it. I'll experiment with pfif-tools and see how much of a hassle it'll be.
The text was updated successfully, but these errors were encountered: