Skip to content

Ensure zerocopy-derive doesn't emit code that assumes a prelude #882

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Tracked by #671
joshlf opened this issue Feb 15, 2024 · 1 comment
Closed
Tracked by #671

Ensure zerocopy-derive doesn't emit code that assumes a prelude #882

joshlf opened this issue Feb 15, 2024 · 1 comment

Comments

@joshlf
Copy link
Member

joshlf commented Feb 15, 2024

Add #![no_implicit_prelude] to every zerocopy-derive test in the zerocopy-derive/tests directory (other than trybuild.rs), and fix whatever breaks. If possible, come up with a more robust strategy to ensure we can't emit code that has this hygiene issue.
@joshlf joshlf mentioned this issue Feb 15, 2024
Open
87 tasks
@joshlf
Copy link
Member Author

joshlf commented Feb 16, 2024

Closed in #886

@joshlf joshlf closed this as completed Feb 16, 2024
@joshlf joshlf mentioned this issue Feb 16, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf