Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

in v10 introduced report parameter omit_unselected_resource_names breaks reports #564

Closed
schabe77 opened this issue Feb 11, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@schabe77
Copy link

Hi,

I use the following query to determine the spent campaign costs per day:
SELECT segments.date, metrics.cost_micros FROM campaign WHERE metrics.cost_micros > 0 AND segments.date BETWEEN '2021-11-12' AND '2022-02-10'
this query gives me per line the costs of a campaign-date combination (I'm not interested in the campaign id, I just sum up the costs).

When using the newly introduces report parameter
SELECT segments.date, metrics.cost_micros FROM campaign WHERE metrics.cost_micros > 0 AND segments.date BETWEEN '2021-11-12' AND '2022-02-10' PARAMETERS omit_unselected_resource_names=true
The costs are far to high for each date per line. It seems like the grouping is somehow broken without the resource name. Each line returns the sum of all campaign costs for that day.

Here an example to make it more clear:
Result without parameter:

2022-02-10    10
2022-02-10    20
2022-02-10    15

Result with parameter

2022-02-10    45
2022-02-10    45
2022-02-10    45

example request ids: TLTjkx6_UiIPoN7y1xL-Cg (with PARAMETERS omit_unselected_resource_names=true), 7QMfkMwYyiQf9XSaDNeFtw (without parameter)

Best regards,

Christian

@schabe77 schabe77 added bug Something isn't working triage labels Feb 11, 2022
@jradcliff jradcliff removed the triage label Feb 11, 2022
@jradcliff jradcliff self-assigned this Feb 11, 2022
@jradcliff
Copy link
Member

Hi Christian,

Thank you very much for pointing this out. I'm following up and will provide updates as soon as I have more info.

-Josh

@jradcliff
Copy link
Member

We released a fix for this yesterday (Feb 14) afternoon and I've checked several queries to confirm their results are now correct. However, please re-open this issue if you still see issues.

Thanks again for highlighting this!

Thanks,
Josh

@schabe77
Copy link
Author

schabe77 commented Mar 4, 2022

I have been using the parameter for more than a week now and just wanted to let you know that everything is now working as expected. Thank you

@jradcliff
Copy link
Member

Great! Thanks for confirming.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants