Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

fix: [gax-java] Add speedy Bazel builds to Travis #1181

Merged
merged 13 commits into from
Sep 15, 2020
Merged

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung requested a review from vam-google September 9, 2020 20:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #1181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1181   +/-   ##
=========================================
  Coverage     78.98%   78.98%           
  Complexity     1194     1194           
=========================================
  Files           205      205           
  Lines          5259     5259           
  Branches        435      435           
=========================================
  Hits           4154     4154           
  Misses          933      933           
  Partials        172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834c05e...ae71fb0. Read the comment docs.

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it! Can we do it as a separate task? Now gradle and bazel go together as a part of the same build, while it would be cleaner if they were two different jobs (this is how ti is done for gapic-generator, for example).

Apart from that, it is simply awesome! Adding bazel build in CI was a long lasting "pending" task that nobody has actually ever done. As you noticed (given the other PR with a fix), the absence of it could cause bazel build for gax to fail even when gradlew one was fine.

@miraleung
Copy link
Contributor Author

No problem. Done, split them into separate tasks.

Base automatically changed from fix/bazel0 to master September 14, 2020 19:38
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just an optional minor comment, feel free to ignore.

@miraleung miraleung merged commit 2fb85fe into master Sep 15, 2020
@miraleung miraleung deleted the fix/bazel1 branch September 15, 2020 20:38
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants