New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: MediaFileUpload error if file does not exist #1127

Merged

gcf-merge-on-green merged 4 commits into googleapis:master from parthea:fix-mediafileupload-invalid-file-exception

Dec 9, 2020

Contributor

parthea commented Dec 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #798 🦕

parthea requested a review from busunkim96

December 7, 2020 12:48

parthea requested a review from a team as a code owner

December 7, 2020 12:48

parthea self-assigned this

google-cla bot added the cla: yes label

parthea mentioned this pull request

fix: add try/except around file descriptor close #800

Closed

busunkim96 reviewed

View reviewed changes

Contributor

busunkim96 left a comment

LGTM. Could you add a new unit test to check the case where no file exists?

parthea requested a review from busunkim96

December 8, 2020 11:57

parthea added the kokoro:force-run label

yoshi-kokoro removed the kokoro:force-run label

parthea added the kokoro:force-run label

yoshi-kokoro removed the kokoro:force-run label

parthea added 2 commits

December 9, 2020 11:18


          fix: MediaFileUpload error if file does not exist

a6e651d


          Add MediaFileUpload test where file does not exist

7acba97

parthea force-pushed the fix-mediafileupload-invalid-file-exception branch from 0550363 to 7acba97 Compare

December 9, 2020 11:18

Contributor

busunkim96 commented Dec 9, 2020

Looks like the 2.7 tests are failing, let's merge #961 first.


          Merge branch 'master' into fix-mediafileupload-invalid-file-exception

a39e8d1

Contributor Author

parthea commented Dec 9, 2020

Hi @busunkim96,

Please can you take a look?

busunkim96 approved these changes

View reviewed changes


          Merge branch 'master' into fix-mediafileupload-invalid-file-exception

d1614ea

parthea added the automerge label

gcf-merge-on-green bot merged commit 2c6d029 into googleapis:master

gcf-merge-on-green bot removed the automerge label

parthea deleted the fix-mediafileupload-invalid-file-exception branch

December 13, 2020 01:33

ycd mentioned this pull request

Raise an exception if MediaUploadFile file path is inacessible #910

Closed

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 2.0.0 (#1129)

a9c7ddc

🤖 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://github.com/googleapis/google-api-python-client/compare/v1.12.8...v2.0.0) (2021-03-03)


### ⚠ BREAKING CHANGES

* **deps:** require 3.6+ (#961)

### Features

* Add support for using static discovery documents ([#1109](https://github.com/googleapis/google-api-python-client/issues/1109)) ([32d1c59](https://github.com/googleapis/google-api-python-client/commit/32d1c597b364e2641eca33ccf6df802bb218eea1))
* Update synth.py to copy discovery files from discovery-artifact-manager ([#1104](https://github.com/googleapis/google-api-python-client/issues/1104)) ([af918e8](https://github.com/googleapis/google-api-python-client/commit/af918e8ef422438aaca0c468de8b3b2c184d884e))


### Bug Fixes

* Catch ECONNRESET and other errors more reliably ([#1147](https://github.com/googleapis/google-api-python-client/issues/1147)) ([ae9cd99](https://github.com/googleapis/google-api-python-client/commit/ae9cd99134160a5540e6f8d6d33d855122854e10))
* **deps:** add upper-bound google-auth dependency ([#1180](https://github.com/googleapis/google-api-python-client/issues/1180)) ([c687f42](https://github.com/googleapis/google-api-python-client/commit/c687f4207b9c574e539a7eab75201a58f2e91f35))
* handle error on service not enabled ([#1117](https://github.com/googleapis/google-api-python-client/issues/1117)) ([c691283](https://github.com/googleapis/google-api-python-client/commit/c6912836e88eea45aef7d515383e549082d37717))
* Improve support for error_details ([#1126](https://github.com/googleapis/google-api-python-client/issues/1126)) ([e6a1da3](https://github.com/googleapis/google-api-python-client/commit/e6a1da3542e230e5287863f339ce1d28292cd92f))
* MediaFileUpload error if file does not exist ([#1127](https://github.com/googleapis/google-api-python-client/issues/1127)) ([2c6d029](https://github.com/googleapis/google-api-python-client/commit/2c6d0297851c806ef850ca23686c51ca5878ac48))
* replace deprecated socket.error with OSError ([#1161](https://github.com/googleapis/google-api-python-client/issues/1161)) ([b7b9986](https://github.com/googleapis/google-api-python-client/commit/b7b9986fe13c483eeefb77673b4091911978ee46))
* Use logging level info when file_cache is not available ([#1125](https://github.com/googleapis/google-api-python-client/issues/1125)) ([0b32e69](https://github.com/googleapis/google-api-python-client/commit/0b32e69900eafec2cd1197ba054d4f9a765a3f29))


### Miscellaneous Chores

* **deps:** require 3.6+ ([#961](https://github.com/googleapis/google-api-python-client/issues/961)) ([8325d24](https://github.com/googleapis/google-api-python-client/commit/8325d24acaa2b2077acaaea26ea5fafb6dd856c5))


### Documentation

* add networkconnectivity v1alpha1 ([#1176](https://github.com/googleapis/google-api-python-client/issues/1176)) ([91b61d3](https://github.com/googleapis/google-api-python-client/commit/91b61d3272de9b5aebad0cf1eb76ca53c24f22f9))
* Delete redundant oauth-web.md ([#1142](https://github.com/googleapis/google-api-python-client/issues/1142)) ([70bc6c9](https://github.com/googleapis/google-api-python-client/commit/70bc6c9db99eed5af7536b87448bd9323db9320b))
* fix MediaIoBaseUpload broken link ([#1112](https://github.com/googleapis/google-api-python-client/issues/1112)) ([334b6e6](https://github.com/googleapis/google-api-python-client/commit/334b6e6d9e4924398e57bad2e53747584abf8cf4))
* fix regression with incorrect args order in docs ([#1141](https://github.com/googleapis/google-api-python-client/issues/1141)) ([4249a7b](https://github.com/googleapis/google-api-python-client/commit/4249a7b92e891d1ecaf93944ca9c062ffbd54f77))
* fix typo in thread safety example code ([#1100](https://github.com/googleapis/google-api-python-client/issues/1100)) ([5ae088d](https://github.com/googleapis/google-api-python-client/commit/5ae088dc027b89517b896a89a0aeb2ca80f492cf))
* Reduce noisy changes in docs regen ([#1135](https://github.com/googleapis/google-api-python-client/issues/1135)) ([b1b0c83](https://github.com/googleapis/google-api-python-client/commit/b1b0c83ae0737e7b63cb77e4e7757213a216b88e))
* update docs/dyn ([#1096](https://github.com/googleapis/google-api-python-client/issues/1096)) ([c2228be](https://github.com/googleapis/google-api-python-client/commit/c2228be4630e279e02a25b51566a0f93b67aa499))
* update guidance on service accounts ([#1120](https://github.com/googleapis/google-api-python-client/issues/1120)) ([b2ea122](https://github.com/googleapis/google-api-python-client/commit/b2ea122c40ccac09c9e7b0b29f6b2bcca6db107b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels