-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Catch ECONNRESET and other errors more reliably #1147
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
I'll squash all the commits to conform to the commit message expectations when/if this is ok to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dossett ! Just one minor observation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dossett , The changes look good. Please could you update the commit message to have prefix fix:
?
@parthea commit message updated, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @dossett !
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://github.com/googleapis/google-api-python-client/compare/v1.12.8...v2.0.0) (2021-03-03) ### ⚠ BREAKING CHANGES * **deps:** require 3.6+ (#961) ### Features * Add support for using static discovery documents ([#1109](https://github.com/googleapis/google-api-python-client/issues/1109)) ([32d1c59](https://github.com/googleapis/google-api-python-client/commit/32d1c597b364e2641eca33ccf6df802bb218eea1)) * Update synth.py to copy discovery files from discovery-artifact-manager ([#1104](https://github.com/googleapis/google-api-python-client/issues/1104)) ([af918e8](https://github.com/googleapis/google-api-python-client/commit/af918e8ef422438aaca0c468de8b3b2c184d884e)) ### Bug Fixes * Catch ECONNRESET and other errors more reliably ([#1147](https://github.com/googleapis/google-api-python-client/issues/1147)) ([ae9cd99](https://github.com/googleapis/google-api-python-client/commit/ae9cd99134160a5540e6f8d6d33d855122854e10)) * **deps:** add upper-bound google-auth dependency ([#1180](https://github.com/googleapis/google-api-python-client/issues/1180)) ([c687f42](https://github.com/googleapis/google-api-python-client/commit/c687f4207b9c574e539a7eab75201a58f2e91f35)) * handle error on service not enabled ([#1117](https://github.com/googleapis/google-api-python-client/issues/1117)) ([c691283](https://github.com/googleapis/google-api-python-client/commit/c6912836e88eea45aef7d515383e549082d37717)) * Improve support for error_details ([#1126](https://github.com/googleapis/google-api-python-client/issues/1126)) ([e6a1da3](https://github.com/googleapis/google-api-python-client/commit/e6a1da3542e230e5287863f339ce1d28292cd92f)) * MediaFileUpload error if file does not exist ([#1127](https://github.com/googleapis/google-api-python-client/issues/1127)) ([2c6d029](https://github.com/googleapis/google-api-python-client/commit/2c6d0297851c806ef850ca23686c51ca5878ac48)) * replace deprecated socket.error with OSError ([#1161](https://github.com/googleapis/google-api-python-client/issues/1161)) ([b7b9986](https://github.com/googleapis/google-api-python-client/commit/b7b9986fe13c483eeefb77673b4091911978ee46)) * Use logging level info when file_cache is not available ([#1125](https://github.com/googleapis/google-api-python-client/issues/1125)) ([0b32e69](https://github.com/googleapis/google-api-python-client/commit/0b32e69900eafec2cd1197ba054d4f9a765a3f29)) ### Miscellaneous Chores * **deps:** require 3.6+ ([#961](https://github.com/googleapis/google-api-python-client/issues/961)) ([8325d24](https://github.com/googleapis/google-api-python-client/commit/8325d24acaa2b2077acaaea26ea5fafb6dd856c5)) ### Documentation * add networkconnectivity v1alpha1 ([#1176](https://github.com/googleapis/google-api-python-client/issues/1176)) ([91b61d3](https://github.com/googleapis/google-api-python-client/commit/91b61d3272de9b5aebad0cf1eb76ca53c24f22f9)) * Delete redundant oauth-web.md ([#1142](https://github.com/googleapis/google-api-python-client/issues/1142)) ([70bc6c9](https://github.com/googleapis/google-api-python-client/commit/70bc6c9db99eed5af7536b87448bd9323db9320b)) * fix MediaIoBaseUpload broken link ([#1112](https://github.com/googleapis/google-api-python-client/issues/1112)) ([334b6e6](https://github.com/googleapis/google-api-python-client/commit/334b6e6d9e4924398e57bad2e53747584abf8cf4)) * fix regression with incorrect args order in docs ([#1141](https://github.com/googleapis/google-api-python-client/issues/1141)) ([4249a7b](https://github.com/googleapis/google-api-python-client/commit/4249a7b92e891d1ecaf93944ca9c062ffbd54f77)) * fix typo in thread safety example code ([#1100](https://github.com/googleapis/google-api-python-client/issues/1100)) ([5ae088d](https://github.com/googleapis/google-api-python-client/commit/5ae088dc027b89517b896a89a0aeb2ca80f492cf)) * Reduce noisy changes in docs regen ([#1135](https://github.com/googleapis/google-api-python-client/issues/1135)) ([b1b0c83](https://github.com/googleapis/google-api-python-client/commit/b1b0c83ae0737e7b63cb77e4e7757213a216b88e)) * update docs/dyn ([#1096](https://github.com/googleapis/google-api-python-client/issues/1096)) ([c2228be](https://github.com/googleapis/google-api-python-client/commit/c2228be4630e279e02a25b51566a0f93b67aa499)) * update guidance on service accounts ([#1120](https://github.com/googleapis/google-api-python-client/issues/1120)) ([b2ea122](https://github.com/googleapis/google-api-python-client/commit/b2ea122c40ccac09c9e7b0b29f6b2bcca6db107b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #1146 🦕