fix: fix .close() #1231
Merged
fix: fix .close() #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
…hon-client into fix-http-close
parthea
approved these changes
Mar 15, 2021
busunkim96
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 31, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://github.com/googleapis/google-api-python-client/compare/v2.0.2...v2.1.0) (2021-03-31) ### Features * add status_code property on http error handling ([#1185](https://github.com/googleapis/google-api-python-client/issues/1185)) ([db2a766](https://github.com/googleapis/google-api-python-client/commit/db2a766bbd976742f6ef10d721d8423c8ac9246d)) ### Bug Fixes * Change default of `static_discovery` when `discoveryServiceUrl` set ([#1261](https://github.com/googleapis/google-api-python-client/issues/1261)) ([3b4f2e2](https://github.com/googleapis/google-api-python-client/commit/3b4f2e243709132b5ca41a3c23853d5067dfb0ab)) * correct api version in oauth-installed.md ([#1258](https://github.com/googleapis/google-api-python-client/issues/1258)) ([d1a255f](https://github.com/googleapis/google-api-python-client/commit/d1a255fcbeaa36f615cede720692fea2b9f894db)) * fix .close() ([#1231](https://github.com/googleapis/google-api-python-client/issues/1231)) ([a9583f7](https://github.com/googleapis/google-api-python-client/commit/a9583f712d13c67aa282d14cd30e00999b530d7c)) * Resolve issue where num_retries would have no effect ([#1244](https://github.com/googleapis/google-api-python-client/issues/1244)) ([c518472](https://github.com/googleapis/google-api-python-client/commit/c518472e836c32ba2ff5e8480ab5a7643f722d46)) ### Documentation * Distinguish between public/private docs in 2.0 guide ([#1226](https://github.com/googleapis/google-api-python-client/issues/1226)) ([a6f1706](https://github.com/googleapis/google-api-python-client/commit/a6f17066caf6e911b7e94e8feab52fa3af2def1b)) * Update README to promote cloud client libraries ([#1252](https://github.com/googleapis/google-api-python-client/issues/1252)) ([22807c9](https://github.com/googleapis/google-api-python-client/commit/22807c92ce754ff3d60f240ec5c38de50c5b654b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
self._http.close(), sincegoogle_auth_httplib2.AuthorizedHttp(googleapis/google-auth-library-python-httplib2@feda187) has been fixed to also have aclosemethod likehttplib2.Http()Fixes #1046 🦕