Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: update GOOGLE_API_USE_MTLS values #940

Merged
merged 1 commit into from
Jun 10, 2020
Merged

fix: update GOOGLE_API_USE_MTLS values #940

merged 1 commit into from
Jun 10, 2020

Conversation

arithmetic1728
Copy link
Contributor

Go client used lower case, so change the values to lower case in python apiary client.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
busunkim96
busunkim96 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth making this case insensitive?

@arithmetic1728
Copy link
Contributor Author

I think I will just use the lower case to be consistent with the Go implementation: https://github.com/googleapis/google-api-go-client/blob/master/transport/http/dial.go#L31-L35

@arithmetic1728 arithmetic1728 merged commit 19908ed into master Jun 10, 2020
@arithmetic1728 arithmetic1728 deleted the sijun-name branch June 10, 2020 05:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@busunkim96 busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithmetic1728 @busunkim96 @googlebot