Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add validation for the token URL and service account impersonation URL for Workload Identity Federation #717

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

lsirac
Copy link
Contributor

@lsirac lsirac commented Aug 11, 2021

Matches the token URLs host to:

  • *.sts.googleapis.com
  • sts.googleapis.com
  • sts.*.googleapis.com
  • *-sts.googleapis.com

Matches the service account impersonation URLs host to:

  • *.iamcredentials.googleapis.com
  • iamcredentials.googleapis.com
  • iamcredentials.*.googleapis.com
  • *-iamcredentials.googleapis.com

Scheme must be HTTPS.

@lsirac lsirac requested a review from a team as a code owner August 11, 2021 01:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@lsirac lsirac requested a review from TimurSadykov August 11, 2021 01:33
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor suggestions on test cases

@lsirac lsirac requested a review from Neenu1995 August 12, 2021 17:38
@lsirac lsirac requested a review from lesv August 12, 2021 20:44
@lsirac lsirac merged commit 23cb8ef into googleapis:master Aug 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants