feat: wrap all python built-in exceptions into library excpetions #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigTailWolf
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
clundin25
reviewed
Nov 18, 2022
BigTailWolf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
BigTailWolf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
BigTailWolf
force-pushed
the
b250060959
branch
from
3ad2ad5 to
1043330
Compare
|
This LGTM. Can you also add automation to prevent unwrapped exceptions from being checked in? |
BigTailWolf
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
|
@BigTailWolf This looks like a big change. Since gcloud is a major customer of google-auth library, could you ask James Wu from gcloud team to see if he has any concerns about it? Thanks! |
|
@BigTailWolf Never mind. Just noticed your new error type inherits the original error type, so I think this should be backward compatible. LGTM |
arithmetic1728
approved these changes
Dec 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer throw raw exception from python.
All the exceptions are throwing through wrapped exception from
google/auth/exceptions.pyso that any client code can catch those exceptions and knowing it's raised by SDK.