Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: AwsCredentials should not call metadata server if security creds and region are retrievable through the environment variables #1195

Merged
merged 8 commits into from
Dec 7, 2022
Merged

feat: AwsCredentials should not call metadata server if security creds and region are retrievable through the environment variables #1195

merged 8 commits into from
Dec 7, 2022

Conversation

BigTailWolf
Copy link
Contributor

No description provided.

@BigTailWolf
feat: AwsCredentials should not call metadata server if security cred…
d39c823 
…s and region are retrievable through the environment variables
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@BigTailWolf BigTailWolf requested a review from lsirac December 2, 2022 23:26
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
lsirac
lsirac reviewed Dec 6, 2022
View reviewed changes
tests/test_aws.py Show resolved Hide resolved
tests/test_aws.py Outdated Show resolved Hide resolved
tests/test_aws.py Show resolved Hide resolved
tests/test_aws.py Show resolved Hide resolved
google/auth/aws.py Outdated Show resolved Hide resolved
google/auth/aws.py Outdated Show resolved Hide resolved
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
lsirac
lsirac reviewed Dec 6, 2022
View reviewed changes
tests/test_aws.py Show resolved Hide resolved
google/auth/aws.py Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2022
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2022
@BigTailWolf BigTailWolf merged commit 5e27c8f into googleapis:main Dec 7, 2022
@release-please release-please bot mentioned this pull request Dec 7, 2022
Merged
@BigTailWolf BigTailWolf deleted the b260006056 branch January 6, 2023 21:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@lsirac lsirac lsirac approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

@sai-sunder-s sai-sunder-s Awaiting requested review from sai-sunder-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BigTailWolf @lsirac @clundin25 @yoshi-kokoro