Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: improve user guide for Impersonation and SA #1627

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: improve user guide for Impersonation and SA #1627

merged 2 commits into from
Nov 8, 2024

Conversation

sai-sunder-s
Copy link
Contributor

No description provided.

@sai-sunder-s sai-sunder-s requested review from a team as code owners November 1, 2024 22:33
westarle
westarle reviewed Nov 6, 2024
View reviewed changes
Copy link

@westarle westarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the impersonation changes, one thing to fix in the service account change.

@sai-sunder-s sai-sunder-s merged commit 656307d into main Nov 8, 2024
15 checks passed
@sai-sunder-s sai-sunder-s deleted the refdocfixit branch November 8, 2024 17:05
@release-please release-please bot mentioned this pull request Nov 8, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@westarle westarle westarle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sai-sunder-s @westarle