Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "fix: update _GOOGLE_OAUTH2_CERTS_URL (#365)" #444

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

k-yone
Copy link
Contributor

@k-yone k-yone commented Feb 14, 2020

Issue

The new certificate (https://www.googleapis.com/oauth2/v3/certs) is in a jwk format and it doesn't match the format expected when decoding a jwt here.
https://github.com/googleapis/google-auth-library-python/blob/master/google/auth/jwt.py#L220

Fix

A quick fix is to revert this update and continue using the /v1 uri.
The decode() function mentioned above should be fixed to accept jwk format certificates in the future.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 14, 2020
@k-yone
Copy link
Contributor Author

k-yone commented Feb 14, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 14, 2020
@k-yone k-yone requested a review from busunkim96 February 14, 2020 08:28
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@busunkim96
Copy link
Contributor

Thank you for the patch @k-yone!

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@busunkim96 busunkim96 merged commit 901c259 into googleapis:master Feb 14, 2020
@release-please release-please bot mentioned this pull request Feb 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants