Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(deps): Revert "fix: pin 'aoihttp < 3.7.0dev' (#634)" (#632) #640

Conversation

davidwtbuxton
Copy link
Contributor

This reverts commit 05f9524.

The compatibility bug was fixed in the aioresponses package version 0.7.1 - https://pypi.org/project/aioresponses/

Fixes #632

This reverts commit 05f9524.

The compatibility bug was fixed in the aioresponses package version 0.7.1.
@davidwtbuxton davidwtbuxton requested a review from a team as a code owner October 29, 2020 21:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2020
@busunkim96 busunkim96 changed the title Revert "fix: pin 'aoihttp < 3.7.0dev' (#634)" (#632) fix(deps): Revert "fix: pin 'aoihttp < 3.7.0dev' (#634)" (#632) Oct 29, 2020
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2020
@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
@busunkim96
Copy link
Contributor

Thank you @davidwtbuxton!

@busunkim96 busunkim96 mentioned this pull request Oct 29, 2020
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 29, 2020
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 29, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b790e65 into googleapis:master Oct 29, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 29, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 29, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.23.0](https://github.com/googleapis/google-auth-library-python/compare/v1.22.1...v1.23.0) (2020-10-29)


### Features

* Add custom scopes for access tokens from the metadata service ([#633](https://github.com/googleapis/google-auth-library-python/issues/633)) ([0323cf3](https://github.com/googleapis/google-auth-library-python/commit/0323cf390b16e8483660ac88775e8ea4e7f7702d))


### Bug Fixes

* **deps:** Revert "fix: pin 'aoihttp < 3.7.0dev' ([#634](https://github.com/googleapis/google-auth-library-python/issues/634))" ([#632](https://github.com/googleapis/google-auth-library-python/issues/632)) ([#640](https://github.com/googleapis/google-auth-library-python/issues/640)) ([b790e65](https://github.com/googleapis/google-auth-library-python/commit/b790e6535cc37591b23866027a426cde312e07c1))
* pin 'aoihttp < 3.7.0dev' ([#634](https://github.com/googleapis/google-auth-library-python/issues/634)) ([05f9524](https://github.com/googleapis/google-auth-library-python/commit/05f95246fab928fe2f445781117eeac8088497fb))
* remove checks for ancient versions of Cryptography ([#596](https://github.com/googleapis/google-auth-library-python/issues/596)) ([6407258](https://github.com/googleapis/google-auth-library-python/commit/6407258956ec42e3b722418cb7f366e5ae9272ec)), closes [/github.com//issues/595#issuecomment-683903062](https://github.com/googleapis//github.com/googleapis/google-auth-library-python/issues/595/issues/issuecomment-683903062)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@davidwtbuxton davidwtbuxton deleted the bugfix/632-remove-aiohttp-pinning branch October 30, 2020 07:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODO: undo pin of 'aiohttp' once 'aioresponses' releases a fix
3 participants