Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

revert: "feat: service account is able to use a private token endpoint (#784)" #808

Merged
merged 2 commits into from
Jul 20, 2021
Merged

revert: "feat: service account is able to use a private token endpoint (#784)" #808

merged 2 commits into from
Jul 20, 2021

Conversation

arithmetic1728
Copy link
Contributor

revert "feat: service account is able to use a private token endpoint (#784)" until b/194191737 is fixed.

This reverts commit 0e26409.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner July 20, 2021 17:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
busunkim96
busunkim96 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small title nit, revert: works as a conventional commit type, could you use that instead?

@busunkim96 busunkim96 linked an issue Jul 20, 2021 that may be closed by this pull request
service account authentication fails after 1.33.0 release #804
Closed
@busunkim96 busunkim96 removed a link to an issue Jul 20, 2021
service account authentication fails after 1.33.0 release #804
Closed
@busunkim96 busunkim96 mentioned this pull request Jul 20, 2021
Closed
@arithmetic1728 arithmetic1728 changed the title fix: revert #784 revert: "feat: service account is able to use a private token endpoint (#784)" Jul 20, 2021
@busunkim96 busunkim96 merged commit d94e65c into master Jul 20, 2021
@busunkim96 busunkim96 deleted the revert_idtoken branch July 20, 2021 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@liuchaoren liuchaoren liuchaoren approved these changes

@silvolu silvolu Awaiting requested review from silvolu

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arithmetic1728 @liuchaoren @busunkim96