fix: aws path normalization in windows #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path normalization for the canonical_uri was broken in windows. This is because we were using `os.path.normpath`. This normalizes "/" paths to "\\" in Windows OS. Confirmed the fix is working in Windows.
bojeil-google
requested review from
arithmetic1728,
silvolu and
a team
as code owners
google-cla
bot
added
the
cla: yes
tseaver
approved these changes
Aug 17, 2021
It was open internally. It went through customer support. I can provide more details or open an issue if needed. Let me know your preference. |
arithmetic1728
approved these changes
Aug 17, 2021
|
@bojeil-google The PR can merge without it, but having a link to the issue in the changelog might help folks figure out whether they had the problem fixed in whatever release. |
|
Fixes #844 |
I agree. Done. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path normalization for the canonical_uri was broken in windows.
This is because we were using
os.path.normpath.This normalizes "/" paths to "\" in Windows OS.
Confirmed the fix is working in Windows.