Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Read Quota Project from Environment Variable #1163

Merged
merged 4 commits into from
Oct 31, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused code
  • Loading branch information
sai-sunder-s committed Oct 31, 2022
commit c6c0104a9d55891c1136ec223bb7d9653e142cd1
1 change: 0 additions & 1 deletion tests/test__default.py
Original file line number Diff line number Diff line change
@@ -1227,7 +1227,6 @@ def test_quota_project_from_environment(get_adc_path):
assert credentials.quota_project_id == "quota_project_id"

quota_from_env = "quota_from_env"
# monkeypatch.setenv(environment_vars.GOOGLE_CLOUD_QUOTA_PROJECT, quota_from_env)
os.environ[environment_vars.GOOGLE_CLOUD_QUOTA_PROJECT] = quota_from_env
credentials, _ = _default.default(quota_project_id=None)
assert credentials.quota_project_id == quota_from_env