-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: fix error in sign_bytes #905
Conversation
The order seems to change sometimes - I think loading the JSON into a dict would make the comparision stable. |
bb797fb
to
01e5242
Compare
I updated the test to just match I also noticed that python nox cover session always includes the |
🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.3](https://github.com/googleapis/google-auth-library-python/compare/v2.3.2...v2.3.3) (2021-11-01) ### Bug Fixes * add fetch_id_token_credentials ([#866](https://github.com/googleapis/google-auth-library-python/issues/866)) ([8f1e9cf](https://github.com/googleapis/google-auth-library-python/commit/8f1e9cfd56dbaae0dff64499e1d0cf55abc5b97e)) * fix error in sign_bytes ([#905](https://github.com/googleapis/google-auth-library-python/issues/905)) ([ef31284](https://github.com/googleapis/google-auth-library-python/commit/ef3128474431b07d1d519209ea61622bc245ce91)) * use 'int.to_bytes' and 'int.from_bytes' for py3 ([#904](https://github.com/googleapis/google-auth-library-python/issues/904)) ([bd0ccc5](https://github.com/googleapis/google-auth-library-python/commit/bd0ccc5fe77d55f7a19f5278d6b60587c393ee3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
fix #851
If
AuthorizedSession.post
failed, we should throw an exception instead of calling thereturn base64.b64decode(response.json()["signedBlob"])
line.