diff --git a/ci/cloudbuild/builds/check-api.sh b/ci/cloudbuild/builds/check-api.sh index 088ddc376900e..0f2604532641f 100755 --- a/ci/cloudbuild/builds/check-api.sh +++ b/ci/cloudbuild/builds/check-api.sh @@ -39,7 +39,7 @@ io::run cmake "${cmake_args[@]}" \ -DGOOGLE_CLOUD_CPP_ENABLE="${ENABLED_FEATURES}" \ -DCMAKE_CXX_FLAGS="-Og -Wno-maybe-uninitialized" io::run cmake --build cmake-out -io::run cmake --install cmake-out #>/dev/null +io::run cmake --install cmake-out >/dev/null if [ "${GOOGLE_CLOUD_CPP_CHECK_API:-}" ]; then IFS=',' read -ra library_list <<<"${GOOGLE_CLOUD_CPP_CHECK_API}" diff --git a/google/cloud/access_token_generator.cc b/google/cloud/access_token_generator.cc index 8d82058ecac4a..53ff5f77e78cb 100644 --- a/google/cloud/access_token_generator.cc +++ b/google/cloud/access_token_generator.cc @@ -23,22 +23,23 @@ namespace { class AccessTokenGeneratorImpl : public AccessTokenGenerator { public: explicit AccessTokenGeneratorImpl( - std::shared_ptr impl) - : impl_(std::move(impl)) {} + std::shared_ptr creds) + : creds_(std::move(creds)) {} ~AccessTokenGeneratorImpl() override = default; StatusOr GetToken() override { - return impl_->GetToken(std::chrono::system_clock::now()); + return creds_->GetToken(std::chrono::system_clock::now()); } private: - std::shared_ptr impl_; + std::shared_ptr creds_; }; } // namespace std::shared_ptr MakeAccessTokenGenerator( - std::shared_ptr credentials) { // NOLINT + // NOLINTNEXTLINE(performance-unnecessary-value-param) + std::shared_ptr credentials) { return std::make_shared( rest_internal::MapCredentials(credentials)); }