Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve retry loop(s) errors #12303

Closed
coryan opened this issue Aug 3, 2023 · 0 comments · Fixed by #12313
Closed

Improve retry loop(s) errors #12303

coryan opened this issue Aug 3, 2023 · 0 comments · Fixed by #12313
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Aug 3, 2023

@dbolduc noted:

observation: in the (rare) exhausted before start case, the error message is a bit redundant:

Retry policy exhausted in <location>:  Retry policy exhausted before first request attempt

I am fine with this.

Originally posted by @dbolduc in #12301 (comment)

and @devbww noted that we repeat "in" in the input to RetryLoopError().


I think we need to create separate functions to return different errors, e.g.:

Status RetryLoopErrorNonIdempotent(Status s, char const* location);
Status RetryLoopErrorFinal(Status s, char const* location, bool exhausted);

In the body of these functions we can implement the formatting as needed.

We should also consider adding information in ErrorInfo() to indicate the type of failure in some kind of machine-consumable form.

@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 3, 2023
@coryan coryan self-assigned this Aug 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant