Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor env vars in GHA scripts to parameters to reduce scope #14572

Open
scotthart opened this issue Jul 25, 2024 · 0 comments
Open

Refactor env vars in GHA scripts to parameters to reduce scope #14572

scotthart opened this issue Jul 25, 2024 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

Several of the bash scripts in ci/gha/builds/*.sh rely on env vars set by the workflow yml files found in .github/workflows to determine execution flow. Most of these would be more appropriate as arguments to the script when it is invoked.

e.g. EXECUTE_INTEGRATION_TESTS, BAZEL_REMOTE_CACHE_RW_MODE, etc.
@scotthart scotthart added the type: cleanup An internal cleanup or hygiene concern. label Jul 25, 2024
@scotthart scotthart mentioned this issue Jul 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scotthart