Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(bigtable): Add client side metrics to feature flag #10678

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Aug 13, 2024

WithFeatureFlags is a client option that allows the user to set feature flags with in all the RPCs. This option should never have been added. This could let the user request features that are not yet supported in the client.

Feature flags should be sent by the client by default.

This PR:

  1. Removes exported WithFeatureFlags option
  2. Adds client side metrics to feature flag

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 13, 2024
@bhshkh bhshkh marked this pull request as ready for review August 13, 2024 06:23
@bhshkh bhshkh requested review from a team as code owners August 13, 2024 06:23
@bhshkh bhshkh marked this pull request as draft August 14, 2024 07:32
@bhshkh bhshkh marked this pull request as ready for review August 19, 2024 16:51
@bhshkh bhshkh requested a review from igorbernstein2 as a code owner August 19, 2024 16:51
@bhshkh bhshkh enabled auto-merge (squash) August 27, 2024 20:01
@bhshkh bhshkh disabled auto-merge August 27, 2024 20:50
@bhshkh bhshkh enabled auto-merge (squash) August 30, 2024 18:59
@bhshkh bhshkh merged commit 02b2d12 into googleapis:main Sep 5, 2024
8 of 10 checks passed
@bhshkh bhshkh deleted the feature/cbt-csm-feature-flag branch September 5, 2024 19:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants