feat(iam/admin): regenerate client #11570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This client has some handwritten code in it that causes failures when generating it normally. I generated the client and hand patched around handwritten code as to not create a breaking change.
codyoss
added
the
do not merge
product-auto-label
bot
added
the
api: iam
codyoss
force-pushed
the
iam-admin-update
branch
from
93d7adc to
1f95c02
Compare
codyoss
force-pushed
the
iam-admin-update
branch
from
1f95c02 to
5ba400d
Compare
codyoss
removed
the
do not merge
quartzmo
approved these changes
Feb 7, 2025
|
@quartzmo I will write a small doc internally. I think what Noah suggested in the linked issue may be the correct long term solution here -- we make a v2 and fix this. What I did was not hard per-say, but it is not super clean or maintainable to do regularly. Or when we implement the selective generation feature, maybe that could help here. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This client has some handwritten code in it that causes failures when generating it normally. I generated the client and hand patched around handwritten code as to not create a breaking change. Changes made:
Fixes: #8219