fix: encode plus # url with %2B #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are not encoding + signs if it part of the URL path, while this is to spec
Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
reserved characters used for their reserved purposes may be used
unencoded within a URL.
It MAY be encoded.
Originally we did encode plus signs, but inappropriately as a space (%20). This was fixed in this PR . However the fix did 2 things, it stopped treating the + sign as a space, but it also stopped encoding it at all. Technically it only need the first fix here. Removing encoding of the + sign caused several APIs to stop working (spreadsheets and gmail).
So this fix is to bring back converting + signs, however due to the original fix, it now converts them correctly to %2B (+), not %20 (space)
Note we still do NOT want + signs to be encoded for SAFEPATHCHARS_URLENCODER, as we still want to utilize it for reserved expansions See issue
Tested: gmail apiary, sheets apiary, storage apiary and gapic
Fixes #20415
Fixes #1573