Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use platform default TCP buffer sizes #855

Merged
merged 3 commits into from
Oct 24, 2019
Merged

fix: use platform default TCP buffer sizes #855

merged 3 commits into from
Oct 24, 2019

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 23, 2019

This is my first and best guess at fixing #820.

@chingor13 @chanseokoh

@elharo elharo requested a review from a team as a code owner October 23, 2019 18:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2019
@elharo elharo changed the title Speed Use platform default TCP buffer sizes Oct 23, 2019
@chanseokoh
Copy link
Contributor

Awesome! Before this PR, as in #820, it took more than 45 seconds.

start timing com.google.api.client.http.apache.v2...
elapsed (s): 48.7

After I built the branch and used 1.32.2-SNAPSHOT, it is now super fast. Thanks for fixing this!

start timing com.google.api.client.http.apache.v2...
elapsed (s): 2.4
start timing com.google.api.client.http.apache.v2...
elapsed (s): 1.7

@chingor13 chingor13 changed the title Use platform default TCP buffer sizes fix: use platform default TCP buffer sizes Oct 24, 2019
@chingor13 chingor13 merged commit 238f4c5 into master Oct 24, 2019
@chingor13 chingor13 deleted the speed branch October 24, 2019 19:17
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
…en-plugin to v1.6.10 (googleapis#855)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.sonatype.plugins:nexus-staging-maven-plugin](http://www.sonatype.com/) ([source](https://github.com/sonatype/nexus-maven-plugins)) | `1.6.8` -> `1.6.10` | [![age](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/compatibility-slim/1.6.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/confidence-slim/1.6.8)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sonatype/nexus-maven-plugins</summary>

### [`v1.6.10`](https://github.com/sonatype/nexus-maven-plugins/compare/release-1.6.9...release-1.6.10)

[Compare Source](https://github.com/sonatype/nexus-maven-plugins/compare/release-1.6.9...release-1.6.10)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants