Skip to content

fix: SAFEPATHCHARS_URLENCODER includes + #955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix: SAFEPATHCHARS_URLENCODER includes + #955

merged 1 commit into from
Jan 22, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 22, 2020 •
edited
Loading

@elharo elharo requested a review from a team as a code owner January 22, 2020 19:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2020
@frankyn frankyn changed the title SAFEPATHCHARS_URLENCODER includes + fix: SAFEPATHCHARS_URLENCODER includes + Jan 22, 2020
frankyn
frankyn approved these changes Jan 22, 2020
View reviewed changes
Copy link

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixes Storage issue -> googleapis/java-storage#57

@chingor13 chingor13 merged commit 9384459 into master Jan 22, 2020
@chingor13 chingor13 deleted the elharo-patch-2 branch January 22, 2020 20:25
elharo
elharo commented Jan 22, 2020
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? This fixed #57? That comes as a complete surprise to me. I thought this was a small no-op cleanup I'd get out of the way before looking for the real bug.

@yoshi-automation yoshi-automation mentioned this pull request Feb 1, 2020
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@lsirac @gcf-owl-bot
fix: updates executable response spec for executable-sourced credenti…
48ff83d 
…als (googleapis#955)

* fix: expiration_time is only required for successful responses when an output file is specified in the credential configuration

* fix: updates PluggableAuthCredentials java docs and missing spot in README

* fix: doc fix

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@release-please
chore(main): release 1.10.0 (googleapis#962)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
79fffe2 
🤖 I have created a release *beep* *boop*
---


## [1.10.0](googleapis/google-auth-library-java@v1.9.0...v1.10.0) (2022-08-05)


### Features

* workforce identity federation for pluggable auth ([googleapis#959](googleapis/google-auth-library-java#959)) ([7f2c535](googleapis/google-auth-library-java@7f2c535))


### Bug Fixes

* updates executable response spec for executable-sourced credentials ([googleapis#955](googleapis/google-auth-library-java#955)) ([48ff83d](googleapis/google-auth-library-java@48ff83d))


### Documentation

* **samples:** added auth samples and tests ([googleapis#927](googleapis/google-auth-library-java#927)) ([32c717f](googleapis/google-auth-library-java@32c717f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chingor13 chingor13

@frankyn frankyn

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @chingor13 @frankyn @googlebot