fix(java): enable skipped tests for Native Image testing #1234

mpeddada1 · 2022-04-21T16:32:06Z

Few changes to note:

Added gax-grpc to emulator module to bring in Native Image netty configurations
Ignoring tests that use Mockito for native image testing
Added resource configuration

mpeddada1 · 2022-04-21T22:55:03Z

According to the logs:

 5 user-provided feature(s)
  - com.google.cloud.nativeimage.features.clients.CloudFunctionsFeature
  - com.google.cloud.nativeimage.features.clients.CloudSqlFeature
  - com.google.cloud.nativeimage.features.clients.SpannerFeature
  - com.oracle.svm.thirdparty.gson.GsonFeature
  - org.graalvm.junit.platform.JUnitPlatformFeature

The features in Gax are not getting picked up

generated-files-bot · 2022-04-22T00:06:54Z

Warning: This pull request is touching the following templated files:

.kokoro/build.sh
.kokoro/presubmit/graalvm-native.cfg

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 · 2022-04-22T02:05:00Z

Native Image Tests are now passing.

mpeddada1 · 2022-05-18T21:23:42Z

@igorbernstein2 thanks again for your suggestions! any chance you could give this another review?

igorbernstein2

lgtm!
thanks for putting this together

igorbernstein2

Oops, noticed one more thing: is there any way to remove the gax dependency?

mpeddada1 · 2022-05-20T19:20:59Z

Oops, noticed one more thing: is there any way to remove the gax dependency?

Mostly summarizing the offline discussion: using a provided scope only allows for the configurations to be included in the test jar. As mentioned here, the native image builder expects the configurations to be embedded into the project JAR through the META-INF/native-image/native-image.properties or META-INF/native-image/reflect-config.json and since com.google.cloud.bigtable.emulator.v2.Emulator references some netty classes, we still need these configurations in the main project JAR.

…cies to v2.11.0 (#1253)

…1255) Source-Link: googleapis/synthtool@505ce5a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* build(fix): add in IT args for graalvm presubmit * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update owlbot.py * it changes * update graalvm config * owlbot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update graalvm-native.cfg Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…er with grpc helpers Currently the emulator exists in a single artifact with optional deps. The reason for this is that bigtable-hbase needs the emulator w/o grpc. However this is causing issues in graalvm packaging in googleapis#1234. This PR makes this easier to manage: a -core artifact without dependencies that just wraps the golang binary that bigtable-hbase can use and a wrapper that has a hard dep on grpc & gax. This is technically a breaking change but the emulator artifact is pre-GA an dis marked with BetaApi

…er with grpc helpers Currently the emulator exists in a single artifact with optional deps. The reason for this is that bigtable-hbase needs the emulator w/o grpc. However this is causing issues in graalvm packaging in googleapis#1234. This PR makes this easier to manage: a -core artifact without dependencies that just wraps the golang binary that bigtable-hbase can use and a wrapper that has a hard dep on grpc & gax. This is technically a breaking change but the emulator artifact is pre-GA an is marked with BetaApi

…r with grpc helpers (#1264) Currently the emulator exists in a single artifact with optional deps. The reason for this is that bigtable-hbase needs the emulator w/o grpc. However this is causing issues in graalvm packaging in #1234. This PR makes this easier to manage: a -core artifact without dependencies that just wraps the golang binary that bigtable-hbase can use and a wrapper that has a hard dep on grpc & gax. This is technically a breaking change but the emulator artifact is pre-GA an is marked with BetaApi Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

mpeddada1 · 2022-05-26T20:07:56Z

@igorbernstein2 thanks for the refactoring! Tests are still green after rebasing.

igorbernstein2

lgtm!
Thanks for all of your patience :)

🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.0...v2.8.0) (2022-05-27) ### Features * split emulator into core without deps and a higher level wrapper with grpc helpers ([#1264](#1264)) ([6fdc2c1](6fdc2c1)) ### Bug Fixes * **java:** enable skipped tests for Native Image testing ([#1234](#1234)) ([560a501](560a501)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mpeddada1 requested a review from a team as a code owner April 21, 2022 16:32

product-auto-label bot added size: u Pull request is empty. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 21, 2022

mpeddada1 requested a review from a team as a code owner April 21, 2022 16:34

product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Apr 21, 2022

product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Apr 22, 2022

mpeddada1 force-pushed the rename-tests branch from d225f40 to 445213f Compare April 22, 2022 00:15

product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Apr 22, 2022

mpeddada1 force-pushed the rename-tests branch 2 times, most recently from 7786ca0 to f4cf569 Compare April 22, 2022 00:28

product-auto-label bot added size: xs Pull request size is extra small. size: s Pull request size is small. and removed size: s Pull request size is small. size: xs Pull request size is extra small. labels Apr 22, 2022

mpeddada1 force-pushed the rename-tests branch from 8767598 to b53f3ce Compare April 22, 2022 01:08

mpeddada1 added 4 commits April 21, 2022 21:32

make gax-grpc a test scope dependency

88f4df4

add resource config

c97371d

skip tests that use mockito

89729be

fix dependency issue

5a31191

mpeddada1 force-pushed the rename-tests branch from d61464a to 5a31191 Compare April 22, 2022 01:36

🦉 Updates from OwlBot post-processor

513a769

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2022

mpeddada1 changed the title ~~fix(java): rename test to be recognized by native profile~~ fix(java): enable skipped tests for Native Image testing Apr 22, 2022

igorbernstein2 approved these changes May 20, 2022

View reviewed changes

igorbernstein2 requested changes May 20, 2022

View reviewed changes

igorbernstein2 mentioned this pull request May 20, 2022

Split emulator into 2 artifacts #1257

Closed

try making gax-grpc provided

d84d2be

mpeddada1 and others added 6 commits May 20, 2022 18:03

explicitly include netty native image configurations

9e29da7

remove gax from used dep setting

8365b6e

deps: update dependency com.google.cloud:google-cloud-shared-dependen…

2386fce

…cies to v2.11.0 (#1253)

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2022

mpeddada1 requested a review from igorbernstein2 May 25, 2022 12:32

igorbernstein2 mentioned this pull request May 26, 2022

feat: split emulator into core without deps and a higher level wrapper with grpc helpers #1264

Merged

4 tasks

mpeddada1 and others added 3 commits May 26, 2022 15:22

Merge branch 'main' into rename-tests

73e1c69

remove netty configs

80b82d8

fix pom.xml

d8f9224

mpeddada1 mentioned this pull request May 26, 2022

chore(main): release 2.8.0 #1265

Merged

igorbernstein2 approved these changes May 26, 2022

View reviewed changes

igorbernstein2 merged commit 560a501 into main May 26, 2022

igorbernstein2 deleted the rename-tests branch May 26, 2022 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(java): enable skipped tests for Native Image testing #1234

fix(java): enable skipped tests for Native Image testing #1234

mpeddada1 commented Apr 21, 2022 •

edited

Loading

mpeddada1 commented Apr 21, 2022

generated-files-bot bot commented Apr 22, 2022 •

edited

Loading

mpeddada1 commented Apr 22, 2022

mpeddada1 commented May 18, 2022 •

edited

Loading

igorbernstein2 left a comment

igorbernstein2 left a comment

mpeddada1 commented May 20, 2022

mpeddada1 commented May 26, 2022

igorbernstein2 left a comment

fix(java): enable skipped tests for Native Image testing #1234

fix(java): enable skipped tests for Native Image testing #1234

Conversation

mpeddada1 commented Apr 21, 2022 • edited Loading

mpeddada1 commented Apr 21, 2022

generated-files-bot bot commented Apr 22, 2022 • edited Loading

mpeddada1 commented Apr 22, 2022

mpeddada1 commented May 18, 2022 • edited Loading

igorbernstein2 left a comment

Choose a reason for hiding this comment

igorbernstein2 left a comment

Choose a reason for hiding this comment

mpeddada1 commented May 20, 2022

mpeddada1 commented May 26, 2022

igorbernstein2 left a comment

Choose a reason for hiding this comment

mpeddada1 commented Apr 21, 2022 •

edited

Loading

generated-files-bot bot commented Apr 22, 2022 •

edited

Loading

mpeddada1 commented May 18, 2022 •

edited

Loading