Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: make channel priming work with batch endpoint #1600

Merged
merged 3 commits into from
Jan 24, 2023
Merged

fix: make channel priming work with batch endpoint #1600

merged 3 commits into from
Jan 24, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jan 24, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf marked this pull request as ready for review January 24, 2023 20:45
@mutianf mutianf requested a review from a team as a code owner January 24, 2023 20:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 24, 2023
kolea2
kolea2 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending hbase testing

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 24, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 24, 2023 21:28
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 24, 2023
@mutianf mutianf merged commit 133c7e5 into googleapis:main Jan 24, 2023
@mutianf mutianf deleted the fix-priming branch January 24, 2023 21:55
@release-please release-please bot mentioned this pull request Jan 24, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2023
@release-please
chore(main): release 2.18.3 (#1601)
04d251e 
🤖 I have created a release *beep* *boop*
---


## [2.18.3](https://github.com/googleapis/java-bigtable/compare/v2.18.2...v2.18.3) (2023-01-24)


### Bug Fixes

* Make channel priming work with batch endpoint ([#1600](https://github.com/googleapis/java-bigtable/issues/1600)) ([133c7e5](https://github.com/googleapis/java-bigtable/commit/133c7e50a5a84e880f23cfc7ed88ea2250a2994d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutianf @kolea2