Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: track the latency a request is queued on the grpc channel #1604

Merged
merged 11 commits into from
Apr 19, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jan 25, 2023

For all operations, it tracks the latency of the request getting queued on a grpc channel. For batch operations, it's the aggregated value of grpc channel queued latency and batcher flow control latencies.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 25, 2023
@mutianf mutianf marked this pull request as ready for review January 25, 2023 21:06
@mutianf mutianf requested a review from a team as a code owner January 25, 2023 21:06
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 17, 2023
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nit

@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 18, 2023
@mutianf mutianf removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 18, 2023
@mutianf mutianf requested a review from a team as a code owner April 18, 2023 19:01
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 19, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit bf3e7dd into googleapis:main Apr 19, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 19, 2023
@mutianf mutianf deleted the tracer branch April 19, 2023 20:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants