Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add @BetaApi for exactly once delivery #1049

Closed
anguillanneuf opened this issue Mar 8, 2022 · 1 comment · Fixed by #1097
Closed

Add @BetaApi for exactly once delivery #1049

anguillanneuf opened this issue Mar 8, 2022 · 1 comment · Fixed by #1097
Assignees
@mmicatka
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Contributor

We did not decorate new methods added by #1022 for exactly once delivery as @BetaApi, but we should do so until the APIs are GA.

See some examples of this for ordering (which are supposed to be removed by now):

java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Lines 320 to 321 in eaeedd8

@BetaApi("Ordering is not yet fully supported and requires special project enablements.")
public void resumePublish(String key) {

java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Lines 803 to 804 in eaeedd8

@BetaApi("Ordering is not yet fully supported and requires special project enablements.")
public Builder setEnableMessageOrdering(boolean enableMessageOrdering) {

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 8, 2022
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 9, 2022
@anguillanneuf anguillanneuf added type: cleanup An internal cleanup or hygiene concern. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 15, 2022
@anguillanneuf
Copy link
Contributor Author

@mmicatka friendly ping.

@mmicatka mmicatka mentioned this issue Apr 21, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mmicatka mmicatka

Labels
api: pubsub Issues related to the googleapis/java-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adding BetaApi annotation for Exactly Once Delivery
3 participants
@anguillanneuf @mmicatka @yoshi-automation