Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add the pubsub lite source reader #13

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Conversation

palmere-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested a review from a team as a code owner July 16, 2021 17:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2021
@palmere-google palmere-google force-pushed the palmere-dev-reader branch 2 times, most recently from feac2c0 to 0c3ff40 Compare July 16, 2021 17:51
@palmere-google palmere-google force-pushed the palmere-dev-reader branch 2 times, most recently from f5eed6d to 147800c Compare July 16, 2021 19:19
Copy link
Contributor

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, please add comments for things I found confusing :)

@palmere-google palmere-google merged commit 2c407e9 into master Jul 20, 2021
@palmere-google palmere-google deleted the palmere-dev-reader branch July 20, 2021 02:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants